Discussion:
createrepo hotfix deployed on ARM (affects all architectures)
James Antill
2012-12-13 14:09:40 UTC
Permalink
Folks,
I tracked down the createrepo stalls to a fundamental bug in createrepo.
I have made the attached patch, a form of which will ultimately be
required for all Fedora architectures.
This has been re-written upstream by Zdeněk for similar reasons (and
should be in rawhide too IIRC) ... can you try that?
Jon Masters
2012-12-13 16:15:25 UTC
Permalink
I don't think we should switch to the rawhide version (this is not in
F18, and it should be, it's going to cause problems), but I am
encouraged that my smaller hotfix is going to be sufficient for now,
since it is even more obviously correct. I think we might be interested
in upgrading, when a fix is pushed to F18 and F17, which should happen
immediately. I hope PA Koji is running a fixed version of createrepo. It
would also be nice if there were some way to get notified of this.
I pulled down the RHEL6.3 and RHEL6.4 versions just now and see that a
fix is in RHEL6.4. RHEL6.3 has an older version with different code. So,
probably this isn't a problem for PA at the moment.

Jon.
Jon Masters
2012-12-13 15:54:12 UTC
Permalink
Post by James Antill
Folks,
I tracked down the createrepo stalls to a fundamental bug in createrepo.
I have made the attached patch, a form of which will ultimately be
required for all Fedora architectures.
This has been re-written upstream by Zdeněk for similar reasons (and
should be in rawhide too IIRC) ... can you try that?
Ah. There we go. When I look in rawhide I see there is some select going
on there now. Well, great. I'm glad someone found that eventually.

I don't think we should switch to the rawhide version (this is not in
F18, and it should be, it's going to cause problems), but I am
encouraged that my smaller hotfix is going to be sufficient for now,
since it is even more obviously correct. I think we might be interested
in upgrading, when a fix is pushed to F18 and F17, which should happen
immediately. I hope PA Koji is running a fixed version of createrepo. It
would also be nice if there were some way to get notified of this.

Note, I didn't notice this because I checked out F18, and because I then
looked to see if F19 had a higher version. "0.9.9" is the version I see
in all of the branches. I (wrongly as it turns out) assumed that this
might bump if such a change had happened. I don't mean to sound grumpy.
I am incredibly annoyed - beyond livid really - but not with you, or
anyone else individually. It's not personal. I'm just annoyed that I
wasted all night and am now exhausted, tracking down something for which
someone has a fix that should have been released already.

Jon.

Loading...