Discussion:
mergerepo.py
s***@osuosl.org
2010-06-01 15:06:00 UTC
Permalink
mergerepo.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit bc3df9bece50098d9dc1c82f0addac36cc1db67a
Author: Seth Vidal <***@fedoraproject.org>
Date: Tue Jun 1 11:06:42 2010 -0400

add --no-database to mergrepo, too

diff --git a/mergerepo.py b/mergerepo.py
index 80ab504..404debe 100755
--- a/mergerepo.py
+++ b/mergerepo.py
@@ -39,7 +39,8 @@ def parse_args(args):
help="repo url")
parser.add_option("-a", "--archlist", default=[], action="append",
help="Defaults to all arches - otherwise specify arches")
- parser.add_option("-d", "--database", default=False, action="store_true")
+ parser.add_option("-d", "--database", default=True, action="store_true")
+ parser.add_option( "--no-database", default=True, action="store_true", dest="nodatabase")
parser.add_option("-o", "--outputdir", default=None,
help="Location to create the repository")
parser.add_option("", "--nogroups", default=False, action="store_true",
@@ -70,8 +71,8 @@ def main(args):
rmbase.archlist = opts.archlist
if opts.outputdir:
rmbase.outputdir = opts.outputdir
- if opts.database:
- rmbase.mdconf.database = True
+ if opts.nodatabase:
+ rmbase.mdconf.database = False
if opts.nogroups:
rmbase.groups = False
if opts.noupdateinfo:
Ville Skyttä
2010-06-01 18:55:23 UTC
Permalink
Post by s***@osuosl.org
+ parser.add_option("-d", "--database", default=True, action="store_true")
+ parser.add_option("--no-database", default=True, action="store_true", dest="nodatabase")
Hmm, both --database and --no-database default to True?
seth vidal
2010-06-01 19:00:46 UTC
Permalink
Post by Ville Skyttä
Post by s***@osuosl.org
+ parser.add_option("-d", "--database", default=True, action="store_true")
+ parser.add_option("--no-database", default=True, action="store_true", dest="nodatabase")
Hmm, both --database and --no-database default to True?
heh
considering how seldom the database item with mergerepo is ever used I
doubt if you hadn't noticed it would ever come up.

I'll fix pronto.

thanks.
-sv
s***@osuosl.org
2010-06-01 19:00:27 UTC
Permalink
mergerepo.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cca1952a84d7cd112f6521573fa8b8a3efec7c96
Author: Seth Vidal <***@fedoraproject.org>
Date: Tue Jun 1 15:01:12 2010 -0400

whoops - no-database shouldn't default to true!

diff --git a/mergerepo.py b/mergerepo.py
index 404debe..05e5f5e 100755
--- a/mergerepo.py
+++ b/mergerepo.py
@@ -40,7 +40,7 @@ def parse_args(args):
parser.add_option("-a", "--archlist", default=[], action="append",
help="Defaults to all arches - otherwise specify arches")
parser.add_option("-d", "--database", default=True, action="store_true")
- parser.add_option( "--no-database", default=True, action="store_true", dest="nodatabase")
+ parser.add_option( "--no-database", default=False, action="store_true", dest="nodatabase")
parser.add_option("-o", "--outputdir", default=None,
help="Location to create the repository")
parser.add_option("", "--nogroups", default=False, action="store_true",
Loading...